feat: add ppm-oidc-client-secret to site secret provisioning#163
Merged
ian-flores merged 1 commit intomainfrom Mar 5, 2026
Merged
feat: add ppm-oidc-client-secret to site secret provisioning#163ian-flores merged 1 commit intomainfrom
ian-flores merged 1 commit intomainfrom
Conversation
Add the ppm-oidc-client-secret key to the SiteSecret struct (Go) and TypedDict (Python). This secret holds the OIDC client secret for PPM's OpenID Connect integration, used by the team-operator to mount the secret into the PPM container. The field is left empty by default — users set it manually after configuring their OIDC provider (e.g., Keycloak). The aws_ensure_secret() merge logic will add the key to existing vaults on the next bootstrap run without disrupting other secrets.
stevenolen
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ppm-oidc-client-secretkey toSiteSecretstruct (Go) and TypedDict (Python)Context
The team-operator now supports PPM OIDC authentication and Identity Federation for authenticated package repos (PTDC-222, PTDC-223, PTDC-224). The operator's
SecretProviderClassexpects appm-oidc-client-secretkey in the site vault to mount into the PPM container at/etc/rstudio-pm/oidc-client-secret.This PR adds the key to the PTD secret provisioning so that:
aws_ensure_secret()merge on next bootstrap runTest plan
just clibuilds successfullyjust checkpasses