Open
Conversation
DavisVaughan
approved these changes
Mar 2, 2026
| #[derive(Debug, Serialize, Deserialize, Clone)] | ||
| pub struct CommInfoRequest { | ||
| pub target_name: String, | ||
| #[serde(default)] |
Contributor
There was a problem hiding this comment.
I noticed that https://github.com/posit-dev/ark/pull/1073/changes#diff-f6c818169bdba550162747979f6b260e31e570d6ed62dc25d2d0a203aa01d114 was also adding default everywhere. What's up with that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1069.
The
target_namefield ofcomm_info_requestis optional in the Jupyter protocol. When absent, the server should provide info for all comms.Currently we're treating
""as the all comm sentinel, but the protocol really specifies the field as optional (can be absent). To fix this, the field is now anOption<String>instead of aString.