DNM-yet: Add VerifyMultiSignature custom signed extension for people-paseo-next#12222
Closed
bkontur wants to merge 1 commit into
Closed
DNM-yet: Add VerifyMultiSignature custom signed extension for people-paseo-next#12222bkontur wants to merge 1 commit into
bkontur wants to merge 1 commit into
Conversation
Contributor
Author
|
closing in favor of polkadot-js/api#6253 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: https://github.com/paritytech/polkadot-sdk/blob/129a48aa9f17a3d5ccbcb8cb4167dd505165d35f/substrate/frame/verify-signature/src/extension.rs#L43
cc: @peetzweg just PoC not sure if I match the runtime spec_name= people-paseo-next, you should be able to run my branch locally and see if it is working for you, then we can finish this PR,
but I think this TX is general and not related to the people, so it should go directly here: https://github.com/polkadot-js/api/blob/master/packages/types/src/extrinsic/signedExtensions/substrate.ts (when can do it afterwards, when we verify that it is working)