This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Add PDF 1.6 Spec Text (or Note) Annotation.#53
Open
mayanez wants to merge 2 commits into
Open
Conversation
mayanez
force-pushed
the
master
branch
2 times, most recently
from
9504173 to
58c8b74
Compare
This add the "Text" annotation as referred to by the PDF spec.
mjbryant
reviewed
Jul 10, 2020
| appearance, | ||
| ) | ||
| # TODO: Proper way to enable? | ||
| # a.add_annotation( |
Contributor
There was a problem hiding this comment.
This looks right. You'd have to run the test and then actually open the PDF and make sure the annotation appears as expected.
Author
There was a problem hiding this comment.
Ok great! I'll test it out and will post an update.
Contributor
|
This looks great! Thanks for the contribution. If you uncomment the integration test lines you added and check the file after the tests have run we can merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add the "Text" annotation as referred to by the PDF spec. These are the "Pop-up" style annotations typically used for comments.
I'm unsure about what the proper changes are for testing so let me know if it needs modification.