This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Addition of Multiple Languages, Refactor and Enhance Notification Store#924
Open
alwialhuda11 wants to merge 3 commits intopkgxdev:mainfrom
Open
Addition of Multiple Languages, Refactor and Enhance Notification Store#924alwialhuda11 wants to merge 3 commits intopkgxdev:mainfrom
alwialhuda11 wants to merge 3 commits intopkgxdev:mainfrom
Conversation
This PR improves the notification store implementation: - Refactored notification creation into a separate `add` function - Removed unused `notifications` array - Increased nanoid length from 4 to 6 for better uniqueness - Simplified `listenToChannel` logic - Made notification type optional in `add` function - Added checks for `params.action` before setting callback - Improved error messaging for invalid notifications These changes enhance code readability, maintainability, and flexibility while preserving existing functionality. Note: The `remove` call in the action callback may need adjustment to target the correct notification ID.
alwialhuda11
changed the title
Author
|
Hello @getneil could you please help to review? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.