Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors repeated keypair-loading logic into a single helper and updates various commands to use it, making the code more DRY.
- Introduces
get_keypairto centralize config loading andKeyDatainstantiation - Updates
print_public_key,get_fingerprint,verify_commit, andsign_from_hexto callget_keypair - Removes duplicated config/keychain/secret-handling code from multiple functions
Comments suppressed due to low confidence (2)
bpb/src/main.rs:108
- Add a doc comment above
get_keypairto explain its purpose (loading config, retrieving the secret, and constructing aKeyData).
fn get_keypair() -> Result<KeyData, Error> {
bpb/src/main.rs:108
- Consider adding unit tests for
get_keypairto cover both successful key loading and error scenarios (e.g., missing keychain item or invalid hex).
fn get_keypair() -> Result<KeyData, Error> {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more DRY