Skip to content

Conversation

@Juliapixel
Copy link
Member

@Juliapixel Juliapixel commented Dec 29, 2025

Description

Rewrites the mostly broken and inaccurate current implementation of H265 depacketization. The previous public APIs were marked as deprecated and replaced with the new XPacketizer and XDepacketizer namings.

The depacketizer implementation was tested to be able to receive an RTP stream from chrome and produce a correct file playable with ffplay, but the packetizer implementation did not produce playable video on chrome, so (if needed) it will be fixed and unprivated in a follow-up PR.

Based on RFC 7798

@Sean-Der
Copy link
Member

This is amazing, thank you so much for doing this @Juliapixel :D

super excited to use this for Broadcast Box seems like most people have HW Accelerated H265 this is gonna help a lot.

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

❌ Patch coverage is 69.37799% with 192 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.93%. Comparing base (5cd305b) to head (4f608ca).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
codecs/h265_packet.go 69.37% 131 Missing and 61 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
- Coverage   89.43%   81.93%   -7.50%     
==========================================
  Files          28       28              
  Lines        3077     3527     +450     
==========================================
+ Hits         2752     2890     +138     
- Misses        217      456     +239     
- Partials      108      181      +73     
Flag Coverage Δ
go 81.93% <69.37%> (-7.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Juliapixel Juliapixel force-pushed the h265-rewrite branch 2 times, most recently from 0202926 to f718ae3 Compare January 1, 2026 21:02
@Juliapixel Juliapixel changed the title Rewrite H265 de/packetizer impl Rewrite H265 depacketizer impl Jan 1, 2026
@Juliapixel Juliapixel marked this pull request as ready for review January 1, 2026 21:05
@Juliapixel Juliapixel requested a review from joturk January 1, 2026 21:06
@Juliapixel Juliapixel force-pushed the h265-rewrite branch 2 times, most recently from 63939e6 to 4f608ca Compare January 2, 2026 03:10
Copy link
Member

@joturk joturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you Julia.

@joturk
Copy link
Member

joturk commented Jan 2, 2026

H265Packet: old is comparable, new is not

Doesn't matter, and H265Packet is deprecated. Many of other codecs depacketizer aren't comparable neither.

The codecov diff is from removing the broken test and deprecating the old public helpers (most of them aren't usable).

Safe to merge.

@joturk
Copy link
Member

joturk commented Jan 2, 2026

merged in 1461347 (we had a race condition with both of us rebasing at the same time :)
Thank you.

@joturk joturk closed this Jan 2, 2026
@Juliapixel Juliapixel mentioned this pull request Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants