-
Notifications
You must be signed in to change notification settings - Fork 122
Rewrite H265 depacketizer impl #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is amazing, thank you so much for doing this @Juliapixel :D super excited to use this for Broadcast Box seems like most people have HW Accelerated H265 this is gonna help a lot. |
584efef to
cda82ab
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
==========================================
- Coverage 89.43% 81.93% -7.50%
==========================================
Files 28 28
Lines 3077 3527 +450
==========================================
+ Hits 2752 2890 +138
- Misses 217 456 +239
- Partials 108 181 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0202926 to
f718ae3
Compare
63939e6 to
4f608ca
Compare
joturk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thank you Julia.
Doesn't matter, and H265Packet is deprecated. Many of other codecs depacketizer aren't comparable neither. The codecov diff is from removing the broken test and deprecating the old public helpers (most of them aren't usable). Safe to merge. |
1461347 to
3cf693c
Compare
|
merged in 1461347 (we had a race condition with both of us rebasing at the same time :) |
Description
Rewrites the mostly broken and inaccurate current implementation of H265 depacketization. The previous public APIs were marked as deprecated and replaced with the new
XPacketizerandXDepacketizernamings.The depacketizer implementation was tested to be able to receive an RTP stream from chrome and produce a correct file playable with
ffplay, but the packetizer implementation did not produce playable video on chrome, so (if needed) it will be fixed and unprivated in a follow-up PR.Based on RFC 7798