Skip to content

feat: make check for updates menu item dynamic#1124

Open
nmggithub wants to merge 4 commits intopingdotgg:mainfrom
nmggithub:make-update-menu-item-dynamic
Open

feat: make check for updates menu item dynamic#1124
nmggithub wants to merge 4 commits intopingdotgg:mainfrom
nmggithub:make-update-menu-item-dynamic

Conversation

@nmggithub
Copy link
Contributor

@nmggithub nmggithub commented Mar 15, 2026

What Changed

EDIT: I was dumb and didn't realize I wasn't actually testing on a newer version of Electron. This PR makes changes and updates electron to the minimal version needed for this feature to work.

This PR cannot be merged in its current state as it depends on features not in upstream Electron yet, but I hope for that to change in the near future. Refs: electron/electron#50266

Once Electron truly supports it, this will allow us to change the label of the "Checking for Updates..." menu item on the fly.

Why

This provides a much better user experience by giving visual indications of what is happening during the update process.

UI Changes

To be added later, when this actually works.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Make the 'Check for Updates' menu item dynamic based on updater state

  • Introduces updateStateListeners, a set of listeners that fire whenever setUpdateState is called, replacing the previous direct emitUpdateState() call.
  • Adds makeCheckForUpdatesMenuItem to create shared MenuItem instances for the macOS app menu and Help menu, and updateCheckForUpdatesMenuItem to update their label and enabled state based on DesktopUpdateState.status.
  • The menu item is disabled and shows status-specific labels (e.g. "Downloading Update…", "Update Available") during all non-idle states, and re-enables when idle.
  • Bumps the electron dependency from 40.6.0 to 40.7.0.

Macroscope summarized 7b1d5e1.

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1ce68cbf-e5b5-437e-beb2-c0727b923caa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 15, 2026
@nmggithub nmggithub changed the title feat: make check for updates menu item dynamic (!waiting for upstream!) feat: make check for updates menu item dynamic Mar 17, 2026
@nmggithub nmggithub force-pushed the make-update-menu-item-dynamic branch from e847533 to 7b1d5e1 Compare March 17, 2026 21:20
@nmggithub nmggithub marked this pull request as ready for review March 17, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant