fix(deps): pin Netty to 4.1.135.Final to fix CVE-2025-24970 (high-severity DoS)#222
Merged
Conversation
grpc-netty 1.60.2 pulls Netty 4.1.100.Final transitively, which is vulnerable to CVE-2025-24970 (HIGH, CVSS 7.5): a crafted packet can crash the native SslHandler (DoS). The fix is Netty 4.1.118.Final+. grpc-netty does not pin a patched Netty even in recent releases, so pin Netty directly. - Pin the three Netty modules that grpc-netty declares directly (netty-codec-http2, netty-handler-proxy, netty-transport-native-unix-common) to 4.1.135.Final. This wins transitive resolution for consumers too (Maven nearest-wins / Gradle highest-wins), so all Netty modules (incl. netty-handler and netty-common) resolve to 4.1.135.Final. - Bump netty-tcnative-boringssl-static 2.0.61.Final -> 2.0.77.Final to match. Also brings in patched netty-codec-http (CVE-2024-29025) and netty-common (CVE-2025-25193). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
rohanshah18
approved these changes
Jun 5, 2026
Contributor
rohanshah18
left a comment
There was a problem hiding this comment.
Thank you for addressing the vulnerability, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CVE-2025-24970 (HIGH, CVSS 7.5) in Netty.
grpc-netty:1.60.2pulls Netty 4.1.100.Final transitively, where a specially crafted packet can crash the nativeSslHandler, causing a denial of service. The fix is Netty ≥ 4.1.118.Final.grpc-netty does not pin a patched Netty even in recent releases (see grpc/grpc-java#11911 — 1.70.0 still scans HIGH), so this pins Netty directly without a large grpc upgrade.
Changes
grpc-nettydeclares directly —netty-codec-http2,netty-handler-proxy,netty-transport-native-unix-common— to 4.1.135.Final.netty-tcnative-boringssl-static2.0.61.Final → 2.0.77.Final (the version paired with Netty 4.1.135).Why pin those three modules
The published artifact is the thin jar with a flat dependency POM (no
<dependencyManagement>), so consumers resolve Netty transitively fromgrpc-netty. A BOM/constraint would not override the transitive version for Maven consumers. Declaring the same three modulesgrpc-nettydeclares — as direct deps at the patched version — makes the patched version win for everyone (Maven nearest-wins, Gradle highest-wins), pulling the whole Netty graph (incl. the vulnerablenetty-handler/netty-common) up to 4.1.135.Bonus
Also brings in patched
netty-codec-http(CVE-2024-29025) andnetty-common(CVE-2025-25193).Verification
./gradlew clean build jar compileIntegrationTestJava→ BUILD SUCCESSFUL, unit tests pass (JDK 17, Gradle 8.5).gradle dependencies --configuration runtimeClasspath→ everyio.netty:*module resolves to 4.1.135.Final (the three4.1.100 -> 4.1.135overrides are visible), tcnative at 2.0.77.Notes
integration-testjob exercises the live gRPC/Netty transport.🤖 Generated with Claude Code
Note
Medium Risk
Changes the gRPC transport stack (Netty/tcnative) for all library consumers; low code churn but affects security-sensitive networking dependencies.
Overview
Pins Netty 4.1.135.Final on the three modules
grpc-nettypulls in directly (netty-codec-http2,netty-handler-proxy,netty-transport-native-unix-common) so Gradle/Maven consumers get patched artifacts instead of 4.1.100.Final fromgrpc-netty:1.60.2, addressing CVE-2025-24970 and related Netty CVEs without upgrading gRPC.Bumps
netty-tcnative-boringssl-staticfrom 2.0.61.Final to 2.0.77.Final to match the pinned Netty line.Reviewed by Cursor Bugbot for commit 7dbacce. Bugbot is set up for automated code reviews on this repo. Configure here.