Harden static telemetry bootstrap and remove committed Kubiks key - #35
Merged
phuquoc81 merged 4 commits intoMar 14, 2026
Merged
Conversation
Co-authored-by: phuquoc81 <51638662+phuquoc81@users.noreply.github.com>
Co-authored-by: phuquoc81 <51638662+phuquoc81@users.noreply.github.com>
Co-authored-by: phuquoc81 <51638662+phuquoc81@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues from Copilot agent using GPT 5.4
Harden static telemetry bootstrap and remove committed Kubiks key
Mar 14, 2026
phuquoc81
approved these changes
Mar 14, 2026
phuquoc81
marked this pull request as ready for review
March 14, 2026 23:59
phuquoc81
changed the base branch from
Main
to
codex/fix-issue-in-fastcash-actions
March 14, 2026 23:59
phuquoc81
merged commit Mar 14, 2026
63e6b59
into
codex/fix-issue-in-fastcash-actions
4 checks passed
There was a problem hiding this comment.
Pull request overview
This PR hardens the static-site OpenTelemetry bootstrap by making telemetry explicitly opt-in at runtime and removing the previously committed Kubiks credential from browser code.
Changes:
- Gate
otel-init.jsloading behind an explicit telemetry enablement flag inindex.html. - Move Kubiks key lookup to runtime-only configuration via query param and/or
localStorage, and skip exporter registration when missing. - Update
TELEMETRY_SETUP.mdto describe the new opt-in + runtime-key flow and remove build-time secret guidance.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
otel-init.js |
Reads Kubiks key at runtime, avoids committed secrets, and conditionally registers exporters/provider. |
index.html |
Dynamically imports telemetry init only when telemetry is explicitly enabled. |
TELEMETRY_SETUP.md |
Updates setup documentation for the opt-in runtime configuration model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Copilot-added telemetry integration introduced static-site regressions and committed a Kubiks credential into the repo. This change narrows telemetry startup to explicit opt-in and moves credential injection to runtime-only configuration.
Telemetry bootstrap
otel-init.jsbehind explicit opt-in inindex.htmlCredential handling
process.envusage with runtime lookup from:?kubiksKey=...localStorage['fastcash.telemetry.kubiksKey']Initialization behavior
otel-init.jssafe for direct import in the browserDocumentation
TELEMETRY_SETUP.mdto describe the static-app flow accurately🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.