Document critical string vs char type distinction in Zephir #4682
+83
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comprehensive documentation clarifying the important differences between string and char types in Zephir: **Key Additions:** 1. **Type System Section Enhancements:** - Clarified that char uses single-quote syntax: 'A' - Emphasized that string indexing (str[i]) returns char, not string - Added that string must use double-quote syntax: "hello" - Noted that single quotes are exclusively for char type 2. **New Dedicated Section: "String vs Char: Key Distinctions":** - Syntax difference table (single vs double quotes) - Detailed explanation of array access returning char - Practical examples showing string iteration yields char types - Type conversion examples (char to string and vice versa) - Common pitfall example showing incorrect char/string comparison 3. **Coding Guidelines Update:** - Added reminder that string indexing returns char type - Emphasized quote usage: single for char, double for string 4. **Common Pitfalls Section:** - Added "String vs Char Confusion" as item #3 - Listed specific gotchas: * str[0] is char type, not string * Quote syntax requirements * Loop variable type when iterating strings * Correct comparison syntax This addresses a critical type distinction that can cause confusion for developers new to Zephir, especially those coming from PHP where this distinction doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.