Update twig deprecated call by it's updated version#518
Closed
allan-simon wants to merge 3 commits intophp-translation:masterfrom
Closed
Update twig deprecated call by it's updated version#518allan-simon wants to merge 3 commits intophp-translation:masterfrom
allan-simon wants to merge 3 commits intophp-translation:masterfrom
Conversation
Version 3.12 of Twig deprecated the use of getNode('filter')
see https://twig.symfony.com/doc/3.x/deprecated.html#nodes
bocharsky-bw
reviewed
Apr 1, 2025
Member
|
Thank you for this change! Could you take a look at the failed test - looks related. I suppose we could fix it with a little version bump for twig package? If so - it should be the easiest fix, otherwise we may need a legacy check and keep both ways. |
|
I believe RemovingNodeVisitor is not the only place where Twig deprecatations are. Can they be removed all at once? |
Author
|
At least it was the only one triggerred in my codebase
…________________________________
De : Roman Pavlík ***@***.***>
Envoyé : mardi 15 avril 2025 08:49
À : php-translation/symfony-bundle ***@***.***>
Cc : Allan Simon ***@***.***>; Author ***@***.***>
Objet : Re: [php-translation/symfony-bundle] Update twig deprecated call by it's updated version (PR #518)
I believe RemovingNodeVisitor is not the only place where Twig deprecatations are. Can they be removed all at once?
image.png (view on web)<https://github.com/user-attachments/assets/4b6c11f9-8631-49cb-80e1-9f7aea9e514f>
—
Reply to this email directly, view it on GitHub<#518 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABUBL22QA4XPM6BLZ7LMFT2ZSTY3AVCNFSM6AAAAAB2G2FCCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBUGAYDAOBVG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/99749?s=20&v=4]ZZromanZZ left a comment (php-translation/symfony-bundle#518)<#518 (comment)>
I believe RemovingNodeVisitor is not the only place where Twig deprecatations are. Can they be removed all at once?
image.png (view on web)<https://github.com/user-attachments/assets/4b6c11f9-8631-49cb-80e1-9f7aea9e514f>
—
Reply to this email directly, view it on GitHub<#518 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABUBL22QA4XPM6BLZ7LMFT2ZSTY3AVCNFSM6AAAAAB2G2FCCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBUGAYDAOBVG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
My try: #519 |
Contributor
|
we must raise min. version from twig to 3.12.0 in |
Member
|
@allan-simon Thank you for this change suggestion! It was applied in #526 along with fixed tests, I'm closign it here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 3.12 of Twig deprecated the use of getNode('filter')
see https://twig.symfony.com/doc/3.x/deprecated.html#nodes