Sort output option added to Po generator #227
Open
vaites wants to merge 3 commits intophp-gettext:masterfrom
Open
Sort output option added to Po generator #227vaites wants to merge 3 commits intophp-gettext:masterfrom
vaites wants to merge 3 commits intophp-gettext:masterfrom
Conversation
briedis
reviewed
Dec 2, 2019
|
|
||
| if ($options['sortOutput'] == true) { | ||
| $translations->uasort(function (Translation $translation1, Translation $translation2) { | ||
| return strcmp($translation1->getOriginal(), $translation2->getTranslation()); |
Contributor
There was a problem hiding this comment.
I don't understand - sorting by comparing original with the translation?
Contributor
Author
There was a problem hiding this comment.
My fault. The comparison must be this:
return strcmp($translation1->getOriginal(), $translation2->getOriginal());Sorry. Must I send a fix or can you change it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated pull request as requested ;)