Open
Conversation
ankurankan
requested changes
Jan 14, 2017
Member
ankurankan
left a comment
There was a problem hiding this comment.
@EricSchles Thanks for the PR. I have a few suggestion for changes:
- In the notebook 1, in the markdown cell next to In[67], you need to change the text saying the accuracy is 56.67 %.
- In the notebook 1, can you also rerun the whole notebook so that all the Input and Out cell numbers are in order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of the work here is very light - pgmpy isn't available in anaconda - so I included a small bit of code -
that looks for the python 3 framework - this only seems to be a problem on mac with jupyter notebook.
This is an initial thought of how to handle this, perhaps some other thoughts would be good around this.