Translate code on english

[zabidenhtf]

No description provided.

[petitlapin]

Thanks for the PR (and the other one in Li-ri-devel). As said in another issue, bumping the year is clearly not the most important for now (as there is no release planned for now).
I'll keep them open and will merge them later when I plan to do a release.

How much do you want to work on improving the game? On my side, I mostly plan to only do minor changes and keep it alive and up-to-date, so I don't have big plans to add new features or major improvements. I've opened a few ideas that could help with the maintenance (such as using sdl_ttf for the texts instead of images, because as you saw, generating the data is complicated and if we want to add languages, it will not be easy or more easy or having the option to not have the human rights questions). Is it something you'd like to work on?
Because if that's the case, I can see to prioritize on my side to fix the issues of non English texts which are blockers to contribute.

[zabidenhtf]

Yes, I’m interested in helping in Li-Ri project. I see potential in this project. :D

[zabidenhtf]

Hello, I have a small question would you be able to merge my PR?

[petitlapin]

Hello, I have a small question would you be able to merge my PR?

Regarding the copyright, I think I'll prefer to do it myself when I'll want to create a new release: the main point is that for the image you didn't use the same font, so I would like to ensure I use the same one as before.
Can you please rename this PR only for renaming and delete the commit regarding the copyright? Then, I'll be able to review it (and please, note it may take some time, I'm working on multiple projects and in real life so I don't have a lot of time for Li-Ri)

[zabidenhtf]

Ok, I'm will fix my errors

[zabidenhtf]

Fixed

[zabidenhtf]

Hello, im removed copyright update from repository.

[zabidenhtf]

Fixed bug. now there no errors (and im fix critical bug with loading screen)

[zabidenhtf]

Hello, im have small question: when will be merged my PR?

[petitlapin]

Hello, im have small question: when will be merged my PR?

I'm copying what I wrote above: "please, note it may take some time, I'm working on multiple projects and in real life so I don't have a lot of time for Li-Ri"

You have to consider:

• I have a life aside of the project so I don't have as much time as you would expect. So it may take a day or a week depending on what I have to do aside.
• You probably did most of the change with an AI or an automatic translator (because you're Ukrainian and the probability of not being fluent in both English and French is really high 😄) but on my side I have to check every translation one by one and ensure there is no regression and it's really the initial meaning (which may be difficult to understand too). And reviewing this number of change takes time.
• I have to consider how much strict I am with the changes: there are some small mistakes, do I take the time to ask you to change all of them (which will bore you at some point), do I merge the PR with these issues, do I want to fix them myself later?

So please, don't get me wrong, I really like your enthusiasm and willingness to improve this game and I hope you will be patient enough to let me the time to review the change and we can discuss the future of the game!

[petitlapin]

Can you please apply the attached patch? The small changes are:

• comply with clang-format (change in game.cc)
• fix the translation in menu.cc (I guess you changed all the "affiche" to "draw" but it was also used on comments and the remaining part of the sentence was kept in French)
• rename DrawL to shouldDrawLoading, this way we don't need to find what is "L" and there is no more comment needed as the variable is self-explanatory.

To apply the patch, copy the file in the root folder and run: git apply patch.diff
patch.txt

Once applied, I'll run again the CI, clang-format should be green, and I'll squash and merge the PR :)

[zabidenhtf]

Ok, sure, but later

[zabidenhtf]

Fixed

[petitlapin]

Thank you again for the changes!