Skip to content

fix: hand off completed triage packets to execution#658

Open
ApexWorm wants to merge 4 commits into
peteromallet:mainfrom
ApexWorm:fix/triage-lifecycle-handoff
Open

fix: hand off completed triage packets to execution#658
ApexWorm wants to merge 4 commits into
peteromallet:mainfrom
ApexWorm:fix/triage-lifecycle-handoff

Conversation

@ApexWorm

Copy link
Copy Markdown

Problem\nCompleted triage could leave queued review IDs in active clusters while the persisted lifecycle remained plan. The snapshot then showed review postflight, and a later reconcile could preserve the wrong phase.\n\n## Fix\nRecognize only a completed triage board whose current review IDs are all triaged, queued, and owned by active clusters. Completion asks the lifecycle pipeline to persist execute for that board; generic, stale, nonqueued, and forced-rescan paths retain normal planning behavior.\n\n## Verification\n- python3 -m pytest -q desloppify/tests/plan\n- python3 -m pytest -q desloppify/tests/commands/plan\n- python3 -m pytest -q desloppify/tests/review/test_work_queue_plan_order_and_triage.py desloppify/tests/commands/scan/test_plan_reconcile_postflight_and_reconcile.py desloppify/tests/commands/test_queue_progress.py desloppify/tests/commands/scan/test_scan_preflight.py\n- python3 -m pytest -q desloppify/tests/engine/test_sync_split_modules_direct.py desloppify/tests/commands/test_postflight_lifecycle_integration.py desloppify/tests/commands/scan/test_plan_reconcile.py desloppify/tests/commands/resolve/test_living_plan_direct.py\n- python3 -m ruff check and ruff format --check on changed files\n\nThe full suite reaches an existing unrelated review prompt assertion failure: test_do_run_batches_dry_run_generates_packet_and_prompts expects "Previously flagged issues" in the generated prompt; it reproduces unchanged from base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant