fix: preserve removed cluster members#657
Open
ApexWorm wants to merge 4 commits into
Open
Conversation
ApexWorm
force-pushed
the
fix/cluster-membership-resurrection
branch
from
July 18, 2026 18:34
b55f1e0 to
8253380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Cluster removal and resolve can remove a member in memory, then normalize it back from historical cluster_add events before the new removal is durably represented. This leaves resolved members in active clusters and can restore stale focus.
Fix: Keep focus cleanup pure so it cannot normalize a just-mutated membership. When purge_ids removes cluster members, append system cluster_remove journal entries before persistence so later normalization retains the removal.
Verification: python3 -m pytest -q desloppify/tests/plan/test_skip.py desloppify/tests/plan/test_schema_migrations.py desloppify/tests/plan/test_auto_cluster.py desloppify/tests/commands/plan/test_cluster_ops_direct.py desloppify/tests/commands/plan/test_cluster_ux.py; python3 -m ruff check desloppify/engine/_plan/operations/lifecycle.py desloppify/tests/plan/test_skip.py