fix: preserve jscpd reports above project threshold#654
Open
liorp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The jscpd adapter inherits a repository's
.jscpd.jsonthreshold. Whenduplication exceeds that threshold, jscpd writes a valid JSON report and exits
report, so scans warn that duplication detection was skipped.
Minimal reproduction:
"threshold": 0.jscpd-report.jsonbut desloppify reportsjscpd exited with errorsand imports no clusters.Fix
Run jscpd with
--threshold 100. Desloppify consumes the report itself, so aproject-level CI threshold must not prevent the adapter from reading valid
results.
Verification
14 passedfor the jscpd adapter tests.6823 passed, 17 skippedfor the full test suite with full extras installed.duplication clusters were imported.