fix: allow targeted review batch imports#653
Open
ApexWorm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A review run intentionally limited with --dimensions completed its batches and merged valid results, but import failed because the trusted-import coverage gate treated every globally unassessed dimension as missing. This made targeted review batches require --allow-partial even when every requested dimension was present.
Fix
Apply the coverage gate only to dimensions in the immutable review packet. The regression tests prove unrelated global gaps are allowed while a missing requested dimension still fails.
Verification
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH="/tmp/desloppify-review-subset-fix" python3 -m pytest -q -p no:cacheprovider desloppify/tests/commands/review/test_review_batch_execution_helpers_direct.py