fix: propagate explicit state through automated triage#646
Open
treygoff24 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Automated Codex/Rovo triage creates
run_desloppify.shfor stage subprocesses, but the wrapper previously preserved only the checkout/interpreter. When the parent invocation used an explicit state file, for example:the generated prompt commands silently fell back to the default/root state. Self-recording stages such as organize then could not match issue IDs from the selected state.
Fix
Pass the active
CommandRuntime.state_pathinto the generated helper. The wrapper inserts--state <path>immediately after every top-level command, so all stage prompt commands (plan,show,next, andbacklog) use the same state as the parent triage run. Default-state runs keep the existing wrapper behavior.Added an executable regression test that records the helper's argv, including a state path containing a space.
Verification
python3 -m pytest desloppify/tests/commands/plan/test_triage_split_modules_direct.py -q— 44 passedruff check . --select E9,F63,F7,F82— passeddesloppify/tests/run: 5661 passed, 152 skipped, with 3 pre-existing Bash unused-source failures reproduced unchanged on pristinemain.desloppify/parent/state.json, listed 20 parent review issues, and successfully added the previously unmatched issue pattern to a test cluster