fix: avoid stale resolve focus#638
Draft
ApexWorm wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resolving an open member auto-focused its cluster using raw remaining membership. A previously fixed member that remained in the cluster could therefore produce a zero-item focused queue while other planned work existed.
Fix
Require a remaining cluster member to be state-open before restore/auto-focus. Retain auto-focus when a live open member remains.
Verification
python3 -m pytest -q desloppify/tests/commands/resolve/test_living_plan_direct.pypython3 -m pytest -q desloppify/tests/commands/resolvepython3 -m ruff check desloppify/app/commands/resolve/living_plan.py desloppify/tests/commands/resolve/test_living_plan_direct.pypython3 -m compileall -q desloppify/app/commands/resolve/living_plan.py desloppify/tests/commands/resolve/test_living_plan_direct.py