fix: preserve tree-sitter import graph edges#634
Open
Rokurolize wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tree-sitter dependency graphs compared resolver-produced absolute paths with project-relative discovery keys. Scans could therefore report zero dependency edges and classify imported files as orphaned; a Wikijump JavaScript scan lost all 129 internal edges.
Fix
Resolve discovery keys to absolute paths for parsing and resolver calls while preserving the original keys in graph output. Match imports through separate normalized filesystem identities, retain exact path casing for I/O, resolve relative resolver results against the scan root, and reject duplicate aliases instead of making edge targets input-order-dependent.
Regression coverage includes relative and absolute key lists, a nested project-root versus scan-root collision, simulated Windows
normcasebehavior, exact resolver arguments, and duplicate aliases in both orders.Validation
pytest -q desloppify/tests/lang/common/test_treesitter_imports_direct.py: 15 passedpytest -q desloppify/tests/lang/common -k treesitter: 177 passed, 1 skippedmainruff check . --select E9,F63,F7,F82: passed