fix(zones): exclude all-test flat directories from scoring#631
Open
FrankSpitulski wants to merge 1 commit into
Open
fix(zones): exclude all-test flat directories from scoring#631FrankSpitulski wants to merge 1 commit into
FrankSpitulski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The flat_dirs detector emits directory paths, but issue zone stamping looked those paths up in a file-only FileZoneMap. A directory containing 29 test-zone files therefore defaulted to production and lowered Code quality from 100 to 86.
Fix
Add a directory-aware zone lookup that inherits a common descendant zone while conservatively keeping mixed or empty directories as production. Use it only for flat_dirs issue stamping, so the advisory remains visible but test-only directories do not affect scoring.
Validation