fix: at selector with value filtering#220
Open
joostdebruijn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in GuessLocator.php where
@...selectors using an optional value would resolve[data-testid=...]/[data-test=...]before applying the[value=...]filter.In grouped radios or checkboxes that share the same test id, that meant assertions and interactions could fall back to the first matching element instead of the one with the requested value. Without this change, calls like
assertRadioSelected('@color', 'blue')could inspect the first@colorradio instead of the radio with valueblue.Test coverage is added to validate the correct behavior.