Exposed guessLocator via element function on Webpage class#219
Open
jack-sandeman wants to merge 1 commit into
Open
Exposed guessLocator via element function on Webpage class#219jack-sandeman wants to merge 1 commit into
jack-sandeman wants to merge 1 commit into
Conversation
Author
|
I've found out that you can access the playwright selectors by using ->page(). I couldn't see any mention of this on the documentation, would it be worth updating? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a question than an improvement. I was wondering why elements aren't exposed to the end user to test directly. To give some context, I ran into a bit of an issue testing where I needed to check the order of elements when using sorting on the page and I couldn't find any way to do it with the current assertion function. This requires the user to use the script function to retrieve element content using querySelector
EG
Resorting to the query selector means that all of playwrights locator magic gets lost! I could be missing something but it seems like it would be useful to be able to access the locator returned from guessLocator directly instead.
EG
Let me know if I'm missing something, or if another approach can be taken.