Skip to content

[FEATURE]: add transforms to the logs table #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shahrokni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FEATURE]: add transforms to the logs table #529

shahrokni wants to merge 1 commit into from

Conversation

@shahrokni
Copy link
Contributor

@shahrokni shahrokni commented Jan 19, 2026 •
edited
Loading

Relates to perses/perses#3786

Description 🖊️

This PR will add the current transform feature to the logs table.

image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@shahrokni shahrokni requested a review from jgbernalp January 19, 2026 12:35
@shahrokni shahrokni force-pushed the feat/add_transform_to_logs_table branch from 48a3ca0 to 9d07767 Compare January 19, 2026 12:39
@shahrokni shahrokni marked this pull request as ready for review January 19, 2026 12:39
@shahrokni shahrokni requested review from a team and AntoineThebaud as code owners January 19, 2026 12:39
jgbernalp
jgbernalp reviewed Jan 19, 2026
View reviewed changes
logstable/src/components/LogsTableTransforms.tsx Outdated
const { onChange, value } = props;

const handleTransformsChange: TransformsEditorProps['onChange'] = (transforms) => {
console.log(transforms);
Copy link
Contributor

@jgbernalp jgbernalp Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(transforms);

Copy link
Contributor Author

@shahrokni shahrokni Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shahrokni
[FEATURE]: add teansform to the logs table
5610fc9 
Signed-off-by: Mahmoud <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the feat/add_transform_to_logs_table branch from 9d07767 to 5610fc9 Compare January 19, 2026 13:36
@shahrokni shahrokni requested a review from jgbernalp January 19, 2026 13:37
@jgbernalp jgbernalp changed the title [FEATURE]: add teansform to the logs table [FEATURE]: add transforms to the logs table Jan 19, 2026
@jgbernalp
Copy link
Contributor

jgbernalp commented Jan 19, 2026

There seems to be an issue with the transforms editor. The columns value which is marked as required is not saved.

Screenshot 2026-01-19 at 15 13 44

@shahrokni
Copy link
Contributor Author

shahrokni commented Jan 19, 2026 •
edited
Loading

There seems to be an issue with the transforms editor. The columns value which is marked as required is not saved.

Screenshot 2026-01-19 at 15 13 44

Shouldn't this be fixed with a dedicated issue for the transform editor?
I just embedded the current existing Transform Editor from the Shared repo into the Logs Table plugin
I have not even added the Extract transformer yet
I myself also found an issue

@jgbernalp
Copy link
Contributor

jgbernalp commented Jan 19, 2026

sure, but why don't do the fix first so we can actually test this is working?

@shahrokni
Copy link
Contributor Author

shahrokni commented Jan 19, 2026

sure, but why don't do the fix first so we can actually test this is working?

Hmm, yes why not. Let's do the fix first.
I am just wondering, if the transform feature has been used seriously so far. It seems there are some serious issues with the feature. Have you ever tried this feature yourself from your side?

@jgbernalp
Copy link
Contributor

jgbernalp commented Jan 19, 2026 •
edited
Loading

I just shared with you my testing of the feature, that's why I found the issue... There's probably a lack of testing for this, as this used to be working before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineThebaud AntoineThebaud Awaiting requested review from AntoineThebaud AntoineThebaud is a code owner

@jgbernalp jgbernalp Awaiting requested review from jgbernalp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shahrokni @jgbernalp