Fix test execution and update README setup steps#6
Open
bhokaremoin wants to merge 3 commits intomainfrom
Open
Conversation
- Add `npx playwright install` to Step 1 for downloading browser binaries - Reword Step 4 as baseline build generation with clearer descriptions - Simplify Step 5 to just run the "after" tests (remove manual code modification instructions and dashboard approval step) - Add node_modules to .gitignore Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test execution fix
junit-jupiter-apidependency frompom.xml.testngundermaven-surefire-plugindependencies to force TestNG provider usage.README updates
npx playwright installcommand to Step 1 for downloading browser binaries.node_modules/to.gitignore.Why
Tests run: 0for configured TestNG suite files.playwright installstep, and had unnecessary manual steps for generating the second build.Validation
npx percy exec --verbose -- mvn test -P web-percy-testTests run: 1)🤖 Generated with Claude Code