Skip to content

Fix test execution and update README setup steps#6

Open
bhokaremoin wants to merge 3 commits intomainfrom
fixing-test-config
Open

Fix test execution and update README setup steps#6
bhokaremoin wants to merge 3 commits intomainfrom
fixing-test-config

Conversation

@bhokaremoin
Copy link
Copy Markdown

@bhokaremoin bhokaremoin commented Mar 23, 2026

Summary

  • Fixes test execution in the Java Playwright Percy example by ensuring Maven Surefire runs TestNG suites correctly.
  • Updates README with correct setup steps and simplified flow based on documentation team feedback.

Changes

Test execution fix

  • Removed junit-jupiter-api dependency from pom.xml.
  • Added testng under maven-surefire-plugin dependencies to force TestNG provider usage.

README updates

  • Added npx playwright install command to Step 1 for downloading browser binaries.
  • Reworded Step 4 as "Generate first Percy build (baseline)" with clearer descriptions.
  • Simplified Step 5 to "Generate second Percy build (with visual changes)" — removed manual code modification instructions and dashboard approval step. Users just run the "after" test which has pre-made visual changes.
  • Added node_modules/ to .gitignore.

Why

  • Surefire was auto-selecting JUnit Platform, resulting in Tests run: 0 for configured TestNG suite files.
  • README was outdated — missing playwright install step, and had unnecessary manual steps for generating the second build.

Validation

  • Ran: npx percy exec --verbose -- mvn test -P web-percy-test
  • Result: Test suite executes correctly (Tests run: 1)

🤖 Generated with Claude Code

@bhokaremoin bhokaremoin requested a review from a team as a code owner March 23, 2026 11:23
- Add `npx playwright install` to Step 1 for downloading browser binaries
- Reword Step 4 as baseline build generation with clearer descriptions
- Simplify Step 5 to just run the "after" tests (remove manual code
  modification instructions and dashboard approval step)
- Add node_modules to .gitignore

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bhokaremoin bhokaremoin changed the title fixing test execution provider Fix test execution and update README setup steps Mar 26, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant