Bump overlay versions#584
Conversation
There was a problem hiding this comment.
Are all of these tests failing or just one?
There was a problem hiding this comment.
I only know 1 was failing, and after bumping all, it worked. But from stellarbeat I see the overlay_version is 36 for all. It shouldn't hurt right?
There was a problem hiding this comment.
I was referring to the tests that you commented out 😅
There was a problem hiding this comment.
Ah... yeah I forgot about our clippy checks. I think all of the commented ones were failing. But I will rollback, we need to fix the tests more thoroughly.
There was a problem hiding this comment.
Hmm now the tests are failing because of the variant mismatch. Which is kinda expected as we are only not properly doing it due to Pendulum....
I can try running the whole test suite locally with the proper variant change.
There was a problem hiding this comment.
Yes we removed those changes (or rather we didn't add them in the last PR) so it's expected that the test chain cannot start.
There was a problem hiding this comment.
Tried testing locally and my tests got stuck here. But... let's not bother too much 😂 probably a different issue. I'm fine if we merge those changes then.
There was a problem hiding this comment.
I always get stuck on those ! no idea why.
2 participants
No description provided.