Move icuTokenizer flag into featureFlags object in config#505
Open
SiarheiFedartsou wants to merge 4 commits intopelias:masterfrom
Open
Move icuTokenizer flag into featureFlags object in config#505SiarheiFedartsou wants to merge 4 commits intopelias:masterfrom
SiarheiFedartsou wants to merge 4 commits intopelias:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
There is a problem is that
schemaconfig is used in other repos as well, e.g. in https://github.com/pelias/dbclient and our config validation is very strict, i.e. it doesn't allow any extra fields (ifunknown(true)is not called explicitly), so we basically cannot set icuTokenizer = true if the same config is used in other repos. So the idea (by @orangejulius) is to introduce separatefeatureFlagsobject in which we have less strict validation.Here's what actually got changed 👏
featureFlagsto config schema (withunknown(true)in order to allow to use the same field in other repos for feature flags if needed)schema.icuTokenizertofeatureFlags.icuTokenizerHere's how others can test the changes 👀
I updated tests...
Previous discussion pelias/dbclient#131