You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there,
I just tried your PR, I think there are no ideal solution here. We are using phrase.* that contains the full address (number + street), since we need to deal with "junk in house number data" and try to match as much as data we can, stripping the alpha is for now the best solution.
Maybe we could also create some post-processing in pelias model to include alias or sanitised names/phrases mixed to a fallback query ?
I have in mind 1 bis, the data may have either 1b, 1 bis or 1bis, in the current state, 1 bis will not match 1bis.
So the model post-processing may replace all 1bis to 1 bis (or add an alias). 1b is a bit tricky since it can be a unit, but as an alias of 1b it should be fine ? The final state might be {"name": {"default": ["1bis Avenue Amélie", "1 bis Avenue Amélie"]}}
Then the query we make could include a should with a minimum_should_match that will query both 1 bis Avenue Amélie and 1 Avenue Amélie as a fallback.
Oh I forgot the case when the user's input is 1bis Avenue Amélie => change to 1 bis Avenue Amélie and if it's 1b Avenue Amélie => IDK if it's safe to include 3 queries, 1b Avenue Amélie, 1 bis Avenue Amélie and 1 Avenue Amélie
It is still an idea and should not be put in this PR, this might be a big change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR upgrades the
pelias/parserversion to latesthttps://github.com/pelias/parser/releases