GRPH-56 Implement transaction size check (18.04)#72
Open
ronakpatel3110 wants to merge 4 commits intodevelopfrom
Open
GRPH-56 Implement transaction size check (18.04)#72ronakpatel3110 wants to merge 4 commits intodevelopfrom
ronakpatel3110 wants to merge 4 commits intodevelopfrom
Conversation
|
@ronakpatel3110 : Can you provide steps to test this ? The QA team will need specific steps to reproduce and test the scenario. |
bobinson
requested changes
Sep 8, 2019
bobinson
left a comment
There was a problem hiding this comment.
- rebase and send the PR to develop
- provide detailed (as detailed as possible) for the QA team to fix it.
added 4 commits
September 9, 2019 10:51
ee14f4d to
b93101c
Compare
Author
|
@bobinson 1) Rebase is done and sent PR to develop 2) It is not possible for QA to check this manually as we need to push many number of operations to reproduce this issue to increase the transaction size. To test this change, a new testcase is added In this test case, we are pushing multiple operations by below loop: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.