Skip to content
This repository was archived by the owner on Nov 22, 2017. It is now read-only.

NineOlds dependency switched to support lib #62#83

Open
redwerk wants to merge 1 commit intopedrovgs:developfrom
redwerk:nineolds_removal
Open

NineOlds dependency switched to support lib #62#83
redwerk wants to merge 1 commit intopedrovgs:developfrom
redwerk:nineolds_removal

Conversation

@redwerk
Copy link
Copy Markdown

@redwerk redwerk commented Jan 12, 2016

No description provided.

@redwerk redwerk mentioned this pull request Jan 12, 2016
Open
pedrovgs
pedrovgs reviewed Jan 31, 2016
View reviewed changes
Comment thread gradle.properties Outdated
Copy link
Copy Markdown
Owner

@pedrovgs pedrovgs Jan 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this target sdk to api 19?

@pedrovgs
Copy link
Copy Markdown
Owner

pedrovgs commented Jan 31, 2016

Hi @redwerk can you also review the usage of the method getSupportActionBar() The code is not compiling because the compiler can't find this method.

@redwerk
Copy link
Copy Markdown
Author

redwerk commented Mar 2, 2016

Hi @pedrovgs ,
Sorry for the long delay response.
I've changed quotes as you wanted.
Changing from target sdk from 19 to 20 was a mistake, sorry about that. Fixed too.
getSupportActionBar() now can be found be compiler.

Thanks!

@redwerk redwerk force-pushed the nineolds_removal branch from 7fea2c7 to def0431 Compare March 2, 2016 16:35
@pedrovgs
Copy link
Copy Markdown
Owner

pedrovgs commented May 10, 2016

Sorry for the delay @redwerk, I've been out for some time. You have some checkstyle issues. Can you review it and fix it to get the build working on travis?

@redwerk redwerk force-pushed the nineolds_removal branch from def0431 to ba9aff0 Compare May 11, 2016 11:53
@redwerk redwerk force-pushed the nineolds_removal branch from ba9aff0 to cebefdf Compare May 11, 2016 12:11
@redwerk
Copy link
Copy Markdown
Author

redwerk commented May 11, 2016

@pedrovgs, I've updated this fix, but it fails again and again, i guess you have to update gradle wrapper to 2.8 version, because everything is ok on my machine and device.

@pedrovgs
Copy link
Copy Markdown
Owner

pedrovgs commented May 18, 2016

Seems related to the Travis-CI configuration. This is the failure output > failed to find target with hash string 'android-23' in: /usr/local/android-sdk Can you take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redwerk @pedrovgs