FISH-13913 SSH Nodes - Convert schtasks to password logon - #8309
Open
kalinchan wants to merge 3 commits into
Open
FISH-13913 SSH Nodes - Convert schtasks to password logon#8309kalinchan wants to merge 3 commits into
kalinchan wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behaviour of Windows SSH Nodes by changing the way instances are launched to use schtasks with the password logon type.
This requires a user to specify the Windows SSH User password via a passwordfile when creating the SSH Node (
AS_ADMIN_SSHPASSWORD={SSH_USER_PASSWORD})For a non admin user on Windows, the following permission is also required
SeBatchLogonRightThis also fixes an issue with the isBehindProxyEnabled method as SSH Nodes do not have the server element.
Important Info
Blockers
n/a
Testing
New tests
Will make another PR
Testing Performed
Manual tested windows and linux nodes both non admin and admin users.
Testing Environment
Windows, Linux, MacOS
Documentation
Pending
Notes for Reviewers
Ensure that non admin windows users have the
SeBatchLogonRightpermission and the ssh password is specified for the node.Also ensure that the required firewall ports are opened