FISH-13978 FISH-13904 Upgrade JLine to 4.3.1 - #8303
Open
kalinchan wants to merge 2 commits into
Open
Conversation
Contributor
|
@kalinchan please merge latest changes from main branch |
Contributor
|
Jenkins test please |
Pandrex247
approved these changes
Jul 31, 2026
Pandrex247
left a comment
Pandrex247
left a comment
Member
There was a problem hiding this comment.
Needs rebasing, but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades JLine to 4.3.1 for security fixes.
Important Info
Blockers
n/a
Testing
New tests
n/a
Testing Performed
Interactive multimode terminal: type asadmin and you get an interactive terminal - run some commands from here
Password prompts: Make asadmin prompt for a password
Do in standard terminal and with an interactive multimode terminal (see above)
Missing parameter prompts: Make asadmin prompt for a missing parameter
Do in standard terminal and with an interactive multimode terminal (see above)
Password files: Pass a password file to asadmin and ensure it doesn’t then prompt for a password.
Remote SSH Test: SSH onto a machine (just standard vanilla SSH, no fancy GUIs or other forwarding) and run the above tests - we need to check asadmin works on limited remote terminals.
OS: Test all of the above on Windows (PowerShell, Git Bash, CMD), on a Linux terminal, and on a Mac terminal
Testing Environment
Documentation
Pending
Notes for Reviewers