Apply crash function to Windows Console via SetConsoleCtrlHandler#141
Open
Apply crash function to Windows Console via SetConsoleCtrlHandler#141
Conversation
Kodikuu
added
the
2. Review requested
dvijayak
approved these changes
Oct 16, 2024
Comment on lines
+235
to
+240
| // Console close == SIGTERM, Ctrl+C == SIGINT | ||
| if (SYSTEM_CRASH_FUNC) | ||
| SYSTEM_CRASH_FUNC(dwCtrlType == CTRL_CLOSE_EVENT || dwCtrlType == CTRL_C_EVENT, SYSTEM_OPAQUE); | ||
|
|
||
| // Prevent secondary calls to the SYSTEM_CRASH_FUNC | ||
| SYSTEM_CRASH_FUNC = NULL; |
There was a problem hiding this comment.
I don't know if you need to protect against multi-threaded scenarios, but perhaps you should do an atomic exchange of the crash func pointer into a local variable while setting the static variable to NULL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs some testing, but this should make application quits more graceful when running with an open console on Windows.
Closing the console or Ctrl+C-ing it will be treated the same as a forced termination via Task Manager
Ctrl+Break acts like a crash, because that's useful to have (Ctrl+C and Ctrl+Break events are when inputting to the console)
Shutdown will plainly exit the application since it shouldn't remain running, while logoff events will leave things down to Windows