reflection: remove unused loop counter in packed_decl_setup#293
Open
heitbaum wants to merge 1 commit intopantoniou:masterfrom
Open
reflection: remove unused loop counter in packed_decl_setup#293heitbaum wants to merge 1 commit intopantoniou:masterfrom
heitbaum wants to merge 1 commit intopantoniou:masterfrom
Conversation
`i` was incremented alongside `declpf` in the field/enum-value iteration loop but its value was never read after assignment. `declpf` already tracks position via pointer arithmetic, making `i` entirely redundant. Drop `i` from the local declaration and simplify the for loop. Fixes -Wunused-but-set-variable warning from GCC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iwas incremented alongsidedeclpfin the field/enum-value iteration loop but its value was never read after assignment.declpfalready tracks position via pointer arithmetic, makingientirely redundant.Drop
ifrom the local declaration and simplify the for loop.Fixes -Wunused-but-set-variable warning from GCC.