Register Leslie/Whirl parameters in initRunningConfig for proper LV2 state report#100
Open
AlmightyFrog wants to merge 1 commit into
Open
Register Leslie/Whirl parameters in initRunningConfig for proper LV2 state report#100AlmightyFrog wants to merge 1 commit into
AlmightyFrog wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am developing a prototypical Android Oboe Wrapper for the LV2 plugin version and came to the issue that not all params can be read out. Here is what i patched locally, maybe you want to have a look to add this or similar to mainline:
Whirl and rotary parameters were not initialized via notifyControlChangeByName() in initRunningConfig(), meaning the LV2 host could not read their initial values.
So i added them missing ones and tried to calculate the correct value looking at b_whirl/whirl.c for each parameters formula.
So values might be off/wrong, for me it sounded rightish but i am no real B3 organ player so I can't gurantee it being correct...