Fixed non static method call & Added query string support#67
Open
andrew-d-moore wants to merge 2 commits intopanique:developfrom
Open
Fixed non static method call & Added query string support#67andrew-d-moore wants to merge 2 commits intopanique:developfrom
andrew-d-moore wants to merge 2 commits intopanique:developfrom
Conversation
Non static method 'openDatabaseConnection' should not be called statically.
Updated the splitUrl function to check requests for query string then parse and create an object from that string. The application constructor will then pass it as a parameter to a constructor function in the Controller Class which populates a private $query_string variable. Note: This includes my fix for the non-static openDatabaseconnection function.
andrew-d-moore
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non static method 'openDatabaseConnection' should not be called statically.