-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
API: to_datetime(ints, unit) give requested unit #63347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
73c582c
0eda6d9
916da40
f9fd868
a5d7e51
a7955da
b62cc4f
edf6864
b6d7953
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -955,7 +955,7 @@ def test_date_format_frame_raises(self, datetime_frame): | |
| ], | ||
| ) | ||
| def test_date_format_series(self, date, date_unit, datetime_series): | ||
| ts = Series(Timestamp(date).as_unit("ns"), index=datetime_series.index) | ||
| ts = Series(Timestamp(date), index=datetime_series.index) | ||
| ts.iloc[1] = pd.NaT | ||
| ts.iloc[5] = pd.NaT | ||
| if date_unit: | ||
|
|
@@ -964,7 +964,7 @@ def test_date_format_series(self, date, date_unit, datetime_series): | |
| json = ts.to_json(date_format="iso") | ||
|
|
||
| result = read_json(StringIO(json), typ="series") | ||
| expected = ts.copy() | ||
| expected = ts.copy().dt.as_unit("ns") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not for this PR, but so this is another case where we currently return ns unit but could change to use us by default?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, but im inclined to leave that to will to decide.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In general I think we should use the same default of microseconds whenever we infer / parse strings, and so for IO formats that means whenever they don't store any type / unit information (in contrast to eg parquet). We already do that for csv, html, excel, etc, so I don't think there is a reason to not do that for JSON. But opened #63442 to track that. |
||
| tm.assert_series_equal(result, expected) | ||
|
|
||
| def test_date_format_series_raises(self, datetime_series): | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -502,7 +502,7 @@ def test_groupby_resample_empty_sum_string( | |
| result = gbrs.sum(min_count=min_count) | ||
|
|
||
| index = pd.MultiIndex( | ||
| levels=[[1, 2, 3], [pd.to_datetime("2000-01-01", unit="ns")]], | ||
| levels=[[1, 2, 3], [pd.to_datetime("2000-01-01", unit="ns").as_unit("ns")]], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did this PR change that? (that this no longer returns nanoseconds)
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but i didn't realize it until I just checked. I thought this PR only affected integer cases. I also didn't think on main that the unit keyword would have any effect in this case. So there's at least two things I need to look into.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK i think ive figured this out. By passing
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe not for this PR, but if specifying
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That's not quite what currently happens. ATM specify any unit means you get "ns". |
||
| codes=[[0, 1, 2], [0, 0, 0]], | ||
| names=["A", None], | ||
| ) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.