Align dynamic pool default protocol fee with docs#260
Open
TUPM96 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the default protocol fee for newly created dynamic fee pools to be 0% (previously 0.03%), and aligns related test expectations and comments.
Changes:
- Change
defaultProtocolFeeForDynamicFeePoolinitial value from300to0. - Update NatSpec/comments to reflect the new 0% default.
- Adjust the corresponding test’s expectation/comment for the default value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/ProtocolFeeController.t.sol | Updates the test constant and assertion comment to match the new 0% default. |
| src/ProtocolFeeController.sol | Changes the contract’s default dynamic-fee protocol fee to 0 and updates NatSpec text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// every newly created dynamic fee pool will have this default protocol fee | ||
| /// @dev 1000 = 0.1%, the initial setting is 0.03% i.e. 3bps | ||
| uint24 public defaultProtocolFeeForDynamicFeePool = 300; | ||
| /// @dev 1000 = 0.1%, the initial setting is 0% |
| /// @notice Set the default protocol fee for dynamic fee pool, this will only impact the newly created dynamic fee pool | ||
| /// all those existing dynamic fee pools will not be affected, they will keep using the default protocol fee set at the time of creation | ||
| /// @param newDefaultProtocolFeeForDynamicFeePool 1000 = 0.1%, the initial setting is 0.03% i.e. 3bps | ||
| /// @param newDefaultProtocolFeeForDynamicFeePool 1000 = 0.1%, the initial setting is 0% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultProtocolFeeForDynamicFeePoolto0so newly created dynamic-fee pools start with no protocol fee.ProtocolFeeControllertest expectations/comments to match the documented 0% dynamic-fee pool protocol fee.Fixes #251
Tests
C:\Users\tupm96\.foundry\versions\v1.7.1\forge.exe test --isolate --match-path test/ProtocolFeeController.t.sol -vv