Align Modules With Shared Cucumber SDK#432
Open
andrea-putzu wants to merge 15 commits into
Open
Conversation
… for bad jwt token
….com/pagopa/selfcare into feature/fix-dependecies-cucumber-sdk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



List of Changes
selfcare-cucumber-sdk.versionproperty in the affected modules and align thedashboard-bffandinstitution-mstest dependencies to version0.1.2.dashboard-bffanduser-group-msCucumber suites so they explicitly load the shared SDK glue and import the SDK beans into the test application context.dashboard-bfftest public key resource and isolate the Docker Compose network names used by the affected integration-test modules.META-INF/beans.xmltoselfcare-cucumber-sdkso Quarkus-based modules such asuser-mscan discover the shared CDI steps provided by the SDK.dashboard-bffand keep the touched test code inproduct-cdcreadable after the dependency update.Motivation and Context
selfcare-cucumber-sdk0.1.2centralizes common step definitions and test utilities, but the modules that consume it were still configured as if those steps and beans lived locally.dashboard-bffanduser-group-mshad collisions between local step definitions and the generic SDK steps.user-msexpected the shared steps to be available as CDI beans, but the SDK was not exposed as a CDI bean archive.How Has This Been Tested?
user-group-ms,dashboard-bff, anduser-msto identify the concrete failures introduced by the SDK upgrade.user-group-msCucumber suite locally with Podman/Testcontainers using the module-specific test command.mvn -f libs/selfcare-cucumber-sdk/pom.xml package -DskipTestsjar tf libs/selfcare-cucumber-sdk/target/selfcare-cucumber-sdk-0.1.2.jar | grep 'META-INF/beans.xml'dashboard-bffcompose and test-support updates locally up to the environment-specific Podman limitations encountered during compose startup.user-msCI log after the dependency upgrade and used the failure output to add the CDI bean-archive fix in the shared SDK.Screenshots (if appropriate):
N/A
Types of changes
Checklist: