Skip to content

Align Modules With Shared Cucumber SDK#432

Open
andrea-putzu wants to merge 15 commits into
mainfrom
feature/fix-dependecies-cucumber-sdk
Open

Align Modules With Shared Cucumber SDK#432
andrea-putzu wants to merge 15 commits into
mainfrom
feature/fix-dependecies-cucumber-sdk

Conversation

@andrea-putzu

@andrea-putzu andrea-putzu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

List of Changes

  • Introduce a shared selfcare-cucumber-sdk.version property in the affected modules and align the dashboard-bff and institution-ms test dependencies to version 0.1.2.
  • Update the dashboard-bff and user-group-ms Cucumber suites so they explicitly load the shared SDK glue and import the SDK beans into the test application context.
  • Rename the local Cucumber steps that overlap with the generic SDK steps and update the related feature files accordingly.
  • Add the missing dashboard-bff test public key resource and isolate the Docker Compose network names used by the affected integration-test modules.
  • Add META-INF/beans.xml to selfcare-cucumber-sdk so Quarkus-based modules such as user-ms can discover the shared CDI steps provided by the SDK.
  • Align the Sonar Maven plugin version in dashboard-bff and keep the touched test code in product-cdc readable after the dependency update.

Motivation and Context

  • selfcare-cucumber-sdk 0.1.2 centralizes common step definitions and test utilities, but the modules that consume it were still configured as if those steps and beans lived locally.
  • After the upgrade, the CI pipeline started failing for different reasons depending on the module:
    • dashboard-bff and user-group-ms had collisions between local step definitions and the generic SDK steps.
    • The Spring-based suites needed explicit wiring to expose the SDK beans inside the test context.
    • user-ms expected the shared steps to be available as CDI beans, but the SDK was not exposed as a CDI bean archive.
  • This PR adapts the affected modules to the shared SDK contract so the monorepo can keep a single implementation of the common Cucumber utilities without breaking the existing integration scenarios.

How Has This Been Tested?

  • Inspected the failing GitHub Actions runs for user-group-ms, dashboard-bff, and user-ms to identify the concrete failures introduced by the SDK upgrade.
  • Validated the user-group-ms Cucumber suite locally with Podman/Testcontainers using the module-specific test command.
  • Validated the shared SDK packaging change locally with:
    • mvn -f libs/selfcare-cucumber-sdk/pom.xml package -DskipTests
    • jar tf libs/selfcare-cucumber-sdk/target/selfcare-cucumber-sdk-0.1.2.jar | grep 'META-INF/beans.xml'
  • Verified the dashboard-bff compose and test-support updates locally up to the environment-specific Podman limitations encountered during compose startup.
  • Reviewed the user-ms CI log after the dependency upgrade and used the failure output to add the CDI bean-archive fix in the shared SDK.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot removed the user-ms label Jun 9, 2026
@andrea-putzu andrea-putzu changed the title feat: update cucumber-sdk dependencies to selfcare-cucumber-sdk version 0.1.2 Align Modules With Shared Cucumber SDK Jun 9, 2026
@github-actions github-actions Bot added the ops label Jun 9, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant