Skip to content

chore(IT-Wallet): [SIW-4332] Renew wallet instance when upgrading to IT-Wallet#8149

Open
gispada wants to merge 8 commits into
masterfrom
SIW-4332-wallet-instance-renewal-on-upgrade
Open

chore(IT-Wallet): [SIW-4332] Renew wallet instance when upgrading to IT-Wallet#8149
gispada wants to merge 8 commits into
masterfrom
SIW-4332-wallet-instance-renewal-on-upgrade

Conversation

@gispada
Copy link
Copy Markdown
Collaborator

@gispada gispada commented Jun 4, 2026

Short description

This PR modifies the Wallet activation flow to create a new Wallet Instance when the user upgrades from "Documenti su IO" to IT-Wallet.

List of changes proposed in this pull request

  • Modified the state machine to transition to WalletInstanceCreation on upgrade
  • Passed isRenewal to registerWalletInstance function
  • Added tests

How to test

  1. Activate Documenti su IO and inspect the network: ensure /api/wallet/uat/v1/wallet-instances is called with is_renewal=false
  2. Upgrade to IT-Wallet and inspect the network: ensure /api/wallet/uat/v1/wallet-instances is called with is_renewal=true

  1. Activate IT-Wallet and inspect the network: ensure /api/wallet/uat/v1/wallet-instances is called with is_renewal=false

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.06%. Comparing base (a7fe60d) to head (7ec78ff).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/itwallet/machine/eid/actors.ts 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8149       +/-   ##
===========================================
- Coverage   62.38%   42.06%   -20.32%     
===========================================
  Files        1946        2     -1944     
  Lines       36781      145    -36636     
  Branches     6092        9     -6083     
===========================================
- Hits        22947       61    -22886     
+ Misses      12478       84    -12394     
+ Partials     1356        0     -1356     
Files with missing lines Coverage Δ
ts/features/itwallet/machine/eid/machine.ts 92.30% <100.00%> (+0.12%) ⬆️
ts/features/itwallet/machine/eid/actors.ts 1.25% <0.00%> (-0.02%) ⬇️

... and 1944 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dec4c2...7ec78ff. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant