fix(IT-Wallet): [SIW-4342] Support vct as URN in remote presentation#8138
Merged
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8138 +/- ##
==========================================
- Coverage 62.35% 62.34% -0.01%
==========================================
Files 1947 1947
Lines 36814 36812 -2
Branches 6128 6129 +1
==========================================
- Hits 22956 22952 -4
- Misses 12504 12505 +1
- Partials 1354 1355 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR updates the function that extracts the credential type from its vct, adding support for URNs. This is a necessary step to fully support the presentation of 1.3 credentials.
List of changes proposed in this pull request
getCredentialTypeByVctand added testsHow to test
Unit tests pass.