Skip to content

fix(IT-Wallet): [SIW-4342] Support vct as URN in remote presentation#8138

Merged
gispada merged 10 commits into
masterfrom
SIW-4342-presentation-urn
Jun 10, 2026
Merged

fix(IT-Wallet): [SIW-4342] Support vct as URN in remote presentation#8138
gispada merged 10 commits into
masterfrom
SIW-4342-presentation-urn

Conversation

@gispada

@gispada gispada commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Short description

This PR updates the function that extracts the credential type from its vct, adding support for URNs. This is a necessary step to fully support the presentation of 1.3 credentials.

List of changes proposed in this pull request

  • Modified getCredentialTypeByVct and added tests
  • Removed the legacy WIA in SD-JWT format from presentation

How to test

Unit tests pass.

@github-actions

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.34%. Comparing base (b6a6740) to head (b20c466).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...res/itwallet/presentation/remote/machine/actors.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8138      +/-   ##
==========================================
- Coverage   62.35%   62.34%   -0.01%     
==========================================
  Files        1947     1947              
  Lines       36814    36812       -2     
  Branches     6128     6129       +1     
==========================================
- Hits        22956    22952       -4     
- Misses      12504    12505       +1     
- Partials     1354     1355       +1     
Files with missing lines Coverage Δ
...ntation/remote/utils/itwRemotePresentationUtils.ts 65.30% <100.00%> (ø)
...res/itwallet/presentation/remote/machine/actors.ts 3.22% <0.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bd07c...b20c466. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mastro993 mastro993 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gispada gispada added this pull request to the merge queue Jun 10, 2026
Merged via the queue into master with commit 12529b1 Jun 10, 2026
12 checks passed
@gispada gispada deleted the SIW-4342-presentation-urn branch June 10, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants