chore(IT-Wallet): [SIW-4277] Add check in status assertion saga to avoid override after playground status selection#8106
Conversation
…tus assertion saga
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8106 +/- ##
===========================================
+ Coverage 62.35% 87.87% +25.52%
===========================================
Files 1942 1 -1941
Lines 36710 33 -36677
Branches 6072 3 -6069
===========================================
- Hits 22890 29 -22861
+ Misses 12469 2 -12467
+ Partials 1351 2 -1349
... and 1941 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I don't agree with this change, we are polluting the code with debug/testing logic. And that's exactly what we need to avoid. |
@mastro993 I agree with you, but I couldn't find another way with the current status override implementation: it writes the modified credential through |
IMHO an override should be just an override. If an user want valid credentials back he needs to issue them again. |
I agree with @mastro993. That saga is a bit too much |
Short description
Remove the persisted playground credential status override behavior, so mocked statuses do not survive app restart and credentials are restored to their real state.
List of changes proposed in this pull request
credentialStatusOverridesfrom being persisted while keepingsavedCredentialsavailable for restore.How to test