Fix benchmark workflow package identity - #307
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the GitHub Actions benchmark workflow by ensuring SwiftPM derives the correct local package identity (MachOKit) during benchmark builds, aligning the workflow checkout directory structure with how Benchmarks/Package.swift references the root package via .package(path: "..").
Changes:
- Check out both candidate and baseline refs into directories named
MachOKit(nested undercandidate/andbaseline/). - Update
CANDIDATE_ROOTandBASELINE_ROOTto point at the nested.../MachOKitdirectories. - Invoke the benchmark script using the new nested candidate path.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MachOKitRoot cause
Benchmarks/Package.swiftdeclares the repository with.package(path: "..")and references the product withpackage: "MachOKit". SwiftPM derives the identity of that local dependency from its directory name. The workflow checked the repository out ascandidateandbaseline, so the candidate dependency was identified ascandidateinstead ofMachOKitand dependency resolution failed.Impact
Manual single-ref and comparison benchmark runs can now resolve the local MachOKit package in GitHub Actions without changing the benchmark package manifest.
Validation
.github/workflows/benchmark.ymlas YAMLbash -n scripts/benchmark.shMachOKitgit diff --checkThe workflow still needs to be re-run on GitHub Actions to verify the hosted-runner execution end to end.