Support swift-syntax version <603.0.0#53
Merged
Merged
Conversation
- logStringInterpolationParsingError
There was a problem hiding this comment.
Pull request overview
Updates the package’s SwiftSyntax compatibility window and adjusts tests to match SwiftSyntaxBuilder API expectations for SwiftSyntax 603.x.
Changes:
- Widen
swift-syntaxdependency upper bound to allow resolving 603.x releases. - Bump
swift-literal-type-inferenceto0.6.0. - Update
PatternBindingSyntax-related tests to use the newer SwiftSyntaxBuilder code-block construction style.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Tests/AssociatedObjectTests/PatternBindingSyntax+Tests.swift |
Updates code-block/getter/willSet construction in tests for SwiftSyntaxBuilder compatibility. |
Package.swift |
Expands SwiftSyntax allowed range and bumps swift-literal-type-inference minimum version. |
Package.resolved |
Updates pinned dependency versions (including swift-syntax 603.0.1). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
22
| .package( | ||
| url: "https://github.com/swiftlang/swift-syntax.git", | ||
| "509.0.0"..<"603.0.0" | ||
| "509.0.0"..<"604.0.0" | ||
| ), |
There was a problem hiding this comment.
The PR title says support for swift-syntax "<603.0.0", but this dependency range change allows resolving 603.x ("509.0.0"..<"604.0.0"). Please clarify intent by updating the PR title/description or adjusting the version range accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.