Reduce min zoom level to 1.0 to allow viewing most of world#2176
Open
otwacam wants to merge 1 commit intoowntracks:masterfrom
Open
Reduce min zoom level to 1.0 to allow viewing most of world#2176otwacam wants to merge 1 commit intoowntracks:masterfrom
otwacam wants to merge 1 commit intoowntracks:masterfrom
Conversation
Contributor
Author
|
Test failures are unrelated to changes and look to be something that can randomly occur. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the map view limits the viewable area meaning it is not possible to all contacts within the world which is unnecessarily restrictive and prevents viewing contacts across a larger area. Additionally the ios version screenshots on the store show a larger view of the map than is possible in the android version.
This change reduces the minimum zoom level to 1.0 to allow viewing of most of the world.
The new zoom levels do go outside the boundaries leading to the map to be repeated but this behaviour can be seen in a number of of other apps and is to be expected for excessive zooming out. Additionally the markers will only be shown on the main section of the map that is visible and will not be duplicated.
Note: I was unable to test the google map layer and have only tested the openstreetmap version as shown below.
Images for comparison:


ios(store screenshot) vs android with minimum zoom level(current)
Android with new minimum zoom levels