Compatibility for ownCoud 11#1329
Open
paulijar wants to merge 5 commits into
Open
Conversation
The `src` attribute of `<img>` doesn't work quite correctly with AngularJS interpolation: the browser first tries to load the image using the uninterpolated raw string before AngularJS has the chance to interpolate the attribute. To work around this, AngularJS has introduced the `ng-src` directive.
The ownCloud v11 has updated Doctrine/DBAL to version 3.x and some previously deprecated functions have been removed. Also Nextcloud uses DBAL 3.x but it apparently provides wrappers for the DBAL classes, providing a legacy-compatible API.
The ownCloud 11 updates the symfony/console version used from the previous 5.4 to 7.4. With 7.4, the `execute` function of each command must declare the return type as `int`. Apparently Nextcloud is still using some older version of symfony/console but the exact version used was not easy to find out.
After the two previous commits, the Music app now seems to work fine on ownCloud 11.0.0-prealpha.
paulijar
force-pushed
the
feature/oc11_compatibility
branch
from
456ff64 to
7fe076d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, seems to work fine on ownCloud 11.0.0-prealpha.