Skip to content

change library dependency#78

Merged
kdubb merged 1 commit into
outfoxx:mainfrom
zunda-pixel:update-library
May 24, 2025
Merged

change library dependency#78
kdubb merged 1 commit into
outfoxx:mainfrom
zunda-pixel:update-library

Conversation

@zunda-pixel
Copy link
Copy Markdown
Contributor

@zunda-pixel zunda-pixel commented Nov 1, 2024 •
edited
Loading

many library requires swift-collections v1.1.x.
so update library.

@zunda-pixel
Copy link
Copy Markdown
Contributor Author

zunda-pixel commented Dec 11, 2024 •
edited
Loading

Hi @kdubb
Can you resolve CI error?
I think CI requires authorization Sonar Cloud.
Thank you

@KINGH242
Copy link
Copy Markdown

KINGH242 commented Mar 17, 2025

Any chance on getting this merged?

@kdubb
Copy link
Copy Markdown
Collaborator

kdubb commented Mar 17, 2025

@zunda-pixel Can you push "something" to trigger the action again.. it's been a while and the logs have been purged.

@zunda-pixel
Copy link
Copy Markdown
Contributor Author

zunda-pixel commented Mar 18, 2025 •
edited
Loading

@kdubb I have pushed, Can you check ci?
I don't have secrets.SONAR_TOKEN

@zunda-pixel zunda-pixel mentioned this pull request Apr 14, 2025
Closed
@zunda-pixel zunda-pixel changed the title update library fix library dependency Apr 15, 2025
@zunda-pixel zunda-pixel changed the title fix library dependency change library dependency Apr 15, 2025
@diederich
Copy link
Copy Markdown

diederich commented May 4, 2025

+1 for getting this in! 🙏

@kdubb
Copy link
Copy Markdown
Collaborator

kdubb commented May 24, 2025

@zunda-pixel @diederich Apologies for the ridiculous delay. I've been extremely busy and it turns out there were a host of issues with the CI setup (#80) that had to be worked through; every time I tried a simple fix I'd run out of time trying to work through them.

@kdubb
Copy link
Copy Markdown
Collaborator

kdubb commented May 24, 2025

And I found a new one! haha... I forgot to up the allow writes to the check api for external PRs 🤦‍♂️

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kdubb kdubb merged commit 56410fc into outfoxx:main May 24, 2025
8 checks passed
@diederich
Copy link
Copy Markdown

diederich commented May 24, 2025

Thanks for finding the time and getting this in! 🙏🏻

@zunda-pixel zunda-pixel deleted the update-library branch May 25, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zunda-pixel @KINGH242 @kdubb @diederich