fix: null-safety and config validation for aws.s3.toggles source#3
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- CoreSourceFactory: validate bucketName and togglesFolder with IllegalArgumentException when missing from configuration - demo/spring/DemoService: use Boolean.TRUE.equals() for null-safe toggle check to prevent NPE on auto-unboxing - CoreSourceFactoryTest: add tests for missing bucket name and folder name validation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
fix: null-safety and config validation for aws.s3.toggles source
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues flagged in review on the
aws.s3.togglessource: missing config validation causing opaque NPEs, and unsafe auto-unboxing of a nullableProperty<Boolean>in the Spring demo.Changes
CoreSourceFactory– ValidatebucketNameandtogglesFolderbefore buildingS3TogglesSource; throwIllegalArgumentExceptionwith the missing key name instead of letting Lombok@NonNullorasS3Folderfail silently with no context:demo/spring/DemoService– Replace auto-unboxings3Toggle1.getValue() ? …withBoolean.TRUE.equals(s3Toggle1.getValue()) ? …to avoid NPE when the toggle is absent. Matches the pattern already used in the Helidon demo.CoreSourceFactoryTest– Two new tests assertIllegalArgumentExceptionis thrown whenbucketNameortogglesFolderis missing from configuration.